[PATCH] D27855: try to extend nonnull-ness of arguments from a callsite back to its parent function

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 09:45:24 PST 2017


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

So as to unblock this review, I suggest that we introduce this change behind an off by default flag.  Separately, we should pursue the clang side changes need to enable this flag by default.  As stated previously, this will benefit my frontend and I'd like to see it land so that I can enable it.

Given the above, LGTM w/the off by default flag and minor comments addressed.



================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:550
+  for (Instruction &I : Entry) {
+    if (auto *Call = dyn_cast<CallInst>(&I)) {
+      unsigned ArgIndex = 0;
----------------
minor: Should handle an invoke terminator as well.


https://reviews.llvm.org/D27855





More information about the llvm-commits mailing list