[PATCH] D29370: [X86] Don't base domain decisions on VEXTRACTF128/VINSERTF128 if only AVX1 is available.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86InstrInfo.cpp:8862
+  { X86::VINSERTF128rr,  X86::VINSERTF128rr,  X86::VINSERTI128rr },
+};
+
----------------
Very minor - but please can you put this table below ReplaceableInstrsAVX2 to match evaluation order


================
Comment at: test/CodeGen/X86/x86-interleaved-access.ll:78
+; AVX2-NEXT:    vmulpd %ymm0, %ymm0, %ymm0
+; AVX2-NEXT:    retq
   %wide.vec = load <16 x double>, <16 x double>* %ptr, align 16
----------------
Annoying but not a real problem.


https://reviews.llvm.org/D29370