[PATCH] D29568: [DAGCombine] Allow vector constant folding of any value type before type legalization

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D29568#673224, @craig.topper wrote:

> LGTM other than my earlier question about the other use of NewNodesMustHaveLegalTypes.


Thanks Craig - sorry I didn't see your comment earlier this week.

NewNodesMustHaveLegalTypes is currently only used during constant creation, where it attempts to expand illegal value types. As NewNodesMustHaveLegalTypes was left stuck in the "true" value for later tests/blocks we were effectively in a 'fail safe' mode that just resulted in (premature?) legalization of constants that seemed to be still handled correctly.


Repository:
  rL LLVM

https://reviews.llvm.org/D29568