[PATCH] D29727: [SLP] Fix for PR31690: Allow using of extra values in horizontal reductions.

[Michael Kuperstein via Phabricator via llvm-commits]

mkuper added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2862
+      DebugLoc DL = ExternallyUsedValues[Scalar];
+      if (auto *VecI = dyn_cast<Instruction>(Vec)) {
+        Builder.SetInsertPoint(VecI->getParent(),
----------------
mkuper wrote:
> I guess it's impossible for Vec to be a PHI here, because the real user is going to be a reduction operation, right?
> If so, how is it possible for it to be a non-Instruction?
Er, actually, what I wrote above doesn't make sense.
Why can't it be a Phi?


https://reviews.llvm.org/D29727