[PATCH] D29751: [libFuzzer] Use dynamic loading for External Functions on Windows.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 17:09:36 PST 2017


amccarth added a comment.

Looks right to me, but I'll leave it to kcc or zturner to accept.



================
Comment at: lib/Fuzzer/FuzzerExtFunctionsDlsymWin.cpp:48
+#include "FuzzerExtFunctions.def"
+#undef EXT_FUNC
+  }
----------------
I thought the LLVM pattern was to have the #undef in the .def file itself.

That's just a style question.  This code is correct.


https://reviews.llvm.org/D29751





More information about the llvm-commits mailing list