[PATCH] D26722: [WebAssembly] Add skeleton MC support for the Wasm container format

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 15:39:29 PST 2017


sunfish marked 4 inline comments as done.
sunfish added a comment.

In https://reviews.llvm.org/D26722#672525, @t.p.northover wrote:

> Some minor comments, but I couldn't see anything immediately wrong with these patches. It's a bit difficult to see the wood for the trees though, with some bits being implemented, some semi-stubs and some complete assertion failures.


Thanks for taking a look! I am hoping to fill in all of the pieces in a series of incremental patches on top of this one. This patch is the base that everything else will build on, so it seemed to make sense to do this first. But I'd be happy to take a different approach if it'd help.


Repository:
  rL LLVM

https://reviews.llvm.org/D26722





More information about the llvm-commits mailing list