[PATCH] D28566: Disable Callee Saved Registers

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi,

High level comment: if we are going to use getUpdatedCalleeSavedReg everywhere in place of getCalleeSavedReg, shouldn't we change directly the implementation of getCalleeSavedReg?
I am afraid that having the distinction is going to be confusing and error-prone.

Cheers,
-Quentin



================
Comment at: include/llvm/CodeGen/MachineRegisterInfo.h:65
 
+  /// CalleeSaveDisableRegs - Lists physical registers that should not be
+  /// preserved.
----------------
Don't repeat the name of the field in the comment.


================
Comment at: include/llvm/CodeGen/MachineRegisterInfo.h:72
+  // This list contains the updated callee saved register list.
+  // On contray to the static list defined in register info, the
+  // all registers that were disabled (in CalleeSaveDisableRegs)
----------------
*contrary
=> As opposed to?


Repository:
  rL LLVM

https://reviews.llvm.org/D28566