[PATCH] D27751: [LLVM] Use after move bug fixes

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 11:53:21 PST 2017


Prazek added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:27000
   while (Mask.size() > 1 && canWidenShuffleElements(Mask, WidenedMask)) {
+    // No use after move, WidenMask reinitialized in canWidenShuffleElements.
     Mask = std::move(WidenedMask);
----------------
Prazek wrote:
> mboehme wrote:
> > Prazek wrote:
> > > mboehme wrote:
> > > > Typo: Should be WidenedMask
> > > btw, why it fires here? It is passed to canWidenShuffleElements by reference and documentation says that it assumes it is being reinitialized in this case.
> > You're right, it shouldn't fire here. I'll take a look at what's going wrong here.
> I was also surprised. Thanks Martin for taking care about it
have you checked this one Martin?


https://reviews.llvm.org/D27751





More information about the llvm-commits mailing list