[PATCH] D29472: [ARM] Add support for armv7ve triple in llvm (PR31358).

[Richard Barton via Phabricator via llvm-commits]

richard.barton.arm requested changes to this revision.
richard.barton.arm added a comment.
This revision now requires changes to proceed.

Hi Manoj

Sorry for not getting back to you yesterday. As you have concluded, ARMv8-R has not got the Security extension, which ruins my idea of neatly encapsulating this in the Virtualization extension definiton.

The new patch is fine save for a missing multiprocessing extension feature in the .td



================
Comment at: lib/Target/ARM/ARM.td:427
+                                                       FeatureVirtualization,
+                                                       FeatureAClass,
+                                                       FeatureT2XtPk]>;
----------------
FeatureMP is missing from here. The Virtualization extension on ARMv7-A requires the MP extension, Security Extension and Divide extensions (and some other things which are not interesting to MC).


https://reviews.llvm.org/D29472