[PATCH] D29766: Add operator bool for MemoryLocations.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 10:03:35 PST 2017


efriedma added a comment.

I'm not sure we want to encourage the use of null MemoryLocations... maybe getLocForWrite() should use `Optional<MemoryLocation>` instead?



================
Comment at: include/llvm/Analysis/MemoryLocation.h:122
+
+  operator bool() const { return Ptr; }
 };
----------------
operator bool() should always be explicit.


Repository:
  rL LLVM

https://reviews.llvm.org/D29766





More information about the llvm-commits mailing list