[PATCH] D29732: [buildbot] Use CmakeCommand
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 9 08:49:00 PST 2017
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:81-84
+ if extra_configure_args:
+ cmake_args = extra_configure_args[:]
+ else:
+ cmake_args = list()
----------------
IMO this is more Python-y:
cmake_args = []
if extra_configure_args:
cmake_args = list(extra_configure_args)
I've always felt that using "[:]" to copy a list was confusing.
https://reviews.llvm.org/D29732
More information about the llvm-commits
mailing list