[PATCH] D29760: [SCEV] NFC. Extract caching logic from the SCEVRewriteVisitor into the CachingSCEVVisitor

[Igor Laevsky via Phabricator via llvm-commits]

igor-laevsky created this revision.
Herald added a subscriber: mzolotukhin.

Sometimes SCEV caching logic is required for the non-rewriting visitors (https://reviews.llvm.org/D29759) . I've extracted it into single abstract place in order to not duplicate it multiple times.


https://reviews.llvm.org/D29760

Files:
  include/llvm/Analysis/ScalarEvolutionExpressions.h


Index: include/llvm/Analysis/ScalarEvolutionExpressions.h
===================================================================
--- include/llvm/Analysis/ScalarEvolutionExpressions.h
+++ include/llvm/Analysis/ScalarEvolutionExpressions.h
@@ -473,6 +473,29 @@
     }
   };
 
+  template <typename SC, typename RetVal = void>
+  class CachingSCEVVisitor : public SCEVVisitor<SC, RetVal> {
+  private:
+    // Memoize the result of each visit so that we only compute once for
+    // the same input SCEV. This is to avoid redundant computations when
+    // a SCEV is referenced by multiple SCEVs. Without memoization, this
+    // visit algorithm would have exponential time complexity in the worst
+    // case, causing the compiler to hang on certain tests.
+    DenseMap<const SCEV *, RetVal> Results;
+
+  public:
+    RetVal visit(const SCEV *S) {
+      auto It = Results.find(S);
+      if (It != Results.end())
+        return It->second;
+
+      RetVal Visited = SCEVVisitor<SC, RetVal>::visit(S);
+      auto Result = Results.try_emplace(S, Visited);
+      assert(Result.second && "Should insert a new entry");
+      return Result.first->second;
+    }
+  };
+
   /// Visit all nodes in the expression tree using worklist traversal.
   ///
   /// Visitor implements:
@@ -566,29 +589,13 @@
   /// The result from each visit is cached, so it will return the same
   /// SCEV for the same input.
   template<typename SC>
-  class SCEVRewriteVisitor : public SCEVVisitor<SC, const SCEV *> {
+  class SCEVRewriteVisitor : public CachingSCEVVisitor<SC, const SCEV *> {
   protected:
     ScalarEvolution &SE;
-    // Memoize the result of each visit so that we only compute once for
-    // the same input SCEV. This is to avoid redundant computations when
-    // a SCEV is referenced by multiple SCEVs. Without memoization, this
-    // visit algorithm would have exponential time complexity in the worst
-    // case, causing the compiler to hang on certain tests.
-    DenseMap<const SCEV *, const SCEV *> RewriteResults;
 
   public:
     SCEVRewriteVisitor(ScalarEvolution &SE) : SE(SE) {}
 
-    const SCEV *visit(const SCEV *S) {
-      auto It = RewriteResults.find(S);
-      if (It != RewriteResults.end())
-        return It->second;
-      auto* Visited = SCEVVisitor<SC, const SCEV *>::visit(S);
-      auto Result = RewriteResults.try_emplace(S, Visited);
-      assert(Result.second && "Should insert a new entry");
-      return Result.first->second;
-    }
-
     const SCEV *visitConstant(const SCEVConstant *Constant) {
       return Constant;
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29760.87802.patch
Type: text/x-patch
Size: 2574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170209/6c7ea2dd/attachment.bin>