[PATCH] D29715: LVI: Add a per-value worklist limit to LazyValueInfo.

[Daniel Berlin via llvm-commits]

Sigh.
Yeah, this is from replacing std::stack, which defaults to deque, with
SmallVector.
The upside is we don't have to pop one at a time, but the downside is it
invalidates references.
Hopefully none others are hiding here.


On Thu, Feb 9, 2017 at 1:43 AM, Vitaly Buka via Phabricator <
reviews at reviews.llvm.org> wrote:

> vitalybuka added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/Analysis/LazyValueInfo.cpp:696
>        // More work needs to be done before revisiting.
> -      assert(BlockValueStack.top() != e && "Stack should have been
> pushed!");
> +      assert(BlockValueStack.back() != e && "Stack should have been
> pushed!");
>      }
> ----------------
> MSAN reported invalid memory access which was fixed with
> https://reviews.llvm.org/rL294572
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D29715
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170209/4beeebd4/attachment.html>