[PATCH] D29714: [ELF] - Do sign extend for addends of R_386_8, R_386_16 relocations

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 01:00:53 PST 2017


grimar added a comment.

In https://reviews.llvm.org/D29714#671060, @ruiu wrote:

> Maybe we need to sign extend everything? In other words, is there any relocation that we shouldn't sign extend?


So just to be clear - we sure can extend everything, but there is no point to do that, its excessive job, so I would probably extend only "short" addends.


https://reviews.llvm.org/D29714





More information about the llvm-commits mailing list