[PATCH] D29710: [globalisel] OperandPredicateMatcher's shouldn't need to generate the MachineOperand expr. NFC
Ahmed Bougacha via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 8 19:02:35 PST 2017
ab accepted this revision.
ab added inline comments.
This revision is now accepted and ready to land.
================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:218
OperandMatcher(unsigned OpIdx) : OpIdx(OpIdx) {}
+ std::string getOperandExpr(const StringRef InsnVarName) const {
+ return (InsnVarName + ".getOperand(" + std::to_string(OpIdx) + ")").str();
----------------
"const StringRef" -> StringRef
(I now realize we had the same elsewhere; fixed that in r294555).
https://reviews.llvm.org/D29710
More information about the llvm-commits
mailing list