[PATCH] D29743: [GlobalISel] Separate the SelectionDAG importer from the emitter. NFC: alternative using Expected<>

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 18:27:14 PST 2017


ab created this revision.
Herald added subscribers: rovka, dberris.

This is an alternative to parts of https://reviews.llvm.org/D29709: instead of appending our new RuleMatcher to a vector, return it and the SkipReason as an Expected<RuleMatcher>.

It's a somewhat unconventional use of Error, but it's nicer than, say, std::pair because of the bool conversions.


https://reviews.llvm.org/D29743

Files:
  utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29743.87746.patch
Type: text/x-patch
Size: 9681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170209/d402c108/attachment.bin>


More information about the llvm-commits mailing list