[PATCH] D29320: [XRay] A tool for Comparing xray function call graphs

[Alexis Shaw via Phabricator via llvm-commits]

varno marked an inline comment as done.
varno added inline comments.


================
Comment at: tools/llvm-xray/xray-graph.h:62
+      Max(_Max), Sum(_Sum){}
+
+    std::string getString(StatType T) const;
----------------
dberris wrote:
> Now that you've defined a default constructor and a non-default constructor, you might as well define (or =default) a copy constructor, a move constructor, a copy+move assignment (probably the unified assignment operator), a swap overload, etc.
> 
> Can you say instead why you needed to do this now?
I was able to remove them by empty list-initializing them where used.


https://reviews.llvm.org/D29320