[PATCH] D28234: Support for custom install dirs in CMake build

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

A few comments inline. Since these variables are used by the LLVM CMake modules, they also need to be added to LLVMConfig.cmake.in. Otherwise they will break out-of-tree builds.



================
Comment at: CMakeLists.txt:310
 
-set(LLVM_TOOLS_INSTALL_DIR "bin" CACHE STRING "Path for binary subdirectory (defaults to 'bin')")
-mark_as_advanced(LLVM_TOOLS_INSTALL_DIR)
+set(LLVM_INSTALL_DOXYGEN_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}/doxygen-html"
+    STRING "Doxygen-generated HTML documentation install directory")
----------------
Since this isn't cached, you also shouldn't put a type or comment.


================
Comment at: CMakeLists.txt:312
+    STRING "Doxygen-generated HTML documentation install directory")
+set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}/ocaml-html"
+    STRING "OCamldoc-generated HTML documentation install directory")
----------------
This one too.


Repository:
  rL LLVM

https://reviews.llvm.org/D28234