[PATCH] D29573: [libunwind][CMake] Use libc++ headers when available

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: CMakeLists.txt:294
+    IS_DIRECTORY "${LIBUNWIND_LIBCXX_INCLUDES_INTERNAL}")
+  set(LIBUNWIND_CXX_INCLUDE_PATHS "${LIBUNWIND_LIBCXX_INCLUDES_INTERNAL}")
+endif()
----------------
I would name this variable with `_DEFAULT` on the end so that it is clear that you're setting the default value for a cached variable.


================
Comment at: CMakeLists.txt:300
+
+include_directories("${LIBUNWIND_CXX_INCLUDE_PATHS}")
+
----------------
Pretty sure `include_directories` can't be called with an empty string, so in the case where find_path fails, this could go wrong.


Repository:
  rL LLVM

https://reviews.llvm.org/D29573