[PATCH] D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 11:02:44 PST 2017


rnk added inline comments.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:133
+    lib_clang_dir = "\\".join([Property("builddir"), config, "lib", "clang"])
+    f.addStep(SetProperty(name="get clang version",
+                          command=["dir", "/b", lib_clang_dir],
----------------
mpividori wrote:
> rnk wrote:
> > This might fail if many version of clang have been built and the lib directory contains more than one version. I suspect the bot already has more than one version directory.
> @rnk yes I considered that. But we are removing the build directory before starting, with the step: `RemoveDirectory(name='clean '+build_dir`
No, that step is conditional on cleanBuildIfRequested, which is typically false. The builder is intended to be fast and incremental.


https://reviews.llvm.org/D29677





More information about the llvm-commits mailing list