[PATCH] D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:148-149
+    # Add fresh clang, tools and compiler-rt dlls to path.
+    Property('slave_env')['Path'] = ";".join([bin_path, dll_path,
+        Property('slave_env')['Path']])
+
----------------
Does this work?  I know `Property('slave_env')` will return the slave environment as a dictionary, but is this just a local dictionary where changes made to it don't get written back to the slave?  That's what I expect.  

If so you might need to do something like

```
newPath = ";".join([bin_path, dll_path, Property('slave_env')['Path']])
f.addStep(SetProperty(name="set toolchain path",
                          command=["set", "PATH", "=", newPath],
                          description="set toolchain path",
                          workdir=build_dir))
```

(I'm honestly not 100% sure though, so confirm that I'm right if you can)


https://reviews.llvm.org/D29677