[PATCH] D28760: [AMDGPU] Add target information that is required by tools to metadata

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPURuntimeMD.cpp:413-428
+  Prog.IsaInfo.WavefrontSize = AMDGPU::IsaInfo::getWavefrontSize(Features);
+  Prog.IsaInfo.LocalMemorySize = AMDGPU::IsaInfo::getLocalMemorySize(Features);
+  Prog.IsaInfo.EUsPerCU = AMDGPU::IsaInfo::getEUsPerCU(Features);
+  Prog.IsaInfo.MaxWavesPerEU = AMDGPU::IsaInfo::getMaxWavesPerEU(Features);
+  Prog.IsaInfo.MaxFlatWorkGroupSize =
+      AMDGPU::IsaInfo::getMaxFlatWorkGroupSize(Features);
+  Prog.IsaInfo.SGPRAllocGranule =
----------------
arsenm wrote:
> Assiging Prog.IsaInfo to a reference variable might help avoid some of the line wrapping?
Sorry, missed this one initially. Submitted follow up patch: rL294454


Repository:
  rL LLVM

https://reviews.llvm.org/D28760