[PATCH] D29715: LVI: Add a per-value worklist limit to LazyValueInfo.

Daniel Jasper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 06:08:44 PST 2017


djasper added inline comments.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:659
+        std::pair<BasicBlock *, Value *> &e = BlockValueStack.top();
+        TheCache.insertResult(e.second, e.first,
+                              LVILatticeVal::getOverdefined());
----------------
Wouldn't this lead to potentially adding Blocks to the cache where we haven't done any search (i.e. that got added after 499 processed values)? Is that a problem?


https://reviews.llvm.org/D29715





More information about the llvm-commits mailing list