[PATCH] D29687: [TargetLowering] check for sign-bit comparisons in SimplifyDemandedBits

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:770
+      // TODO: Should we check for other forms of sign-bit comparisons?
+      // Examples: X <= -1, X >= 0
+    }
----------------
Add test cases for these?


================
Comment at: test/CodeGen/X86/vselect-pcmp.ll:4
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=avx2      | FileCheck %s --check-prefix=AVX --check-prefix=AVX2
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=avx512f  | FileCheck %s --check-prefix=AVX --check-prefix=AVX512F
 
----------------
Please can you add a avx512vl target to check more mask predicate cases?


https://reviews.llvm.org/D29687