[PATCH] D29586: [lsan] Enable LSan for arm Linux

[Maxim Ostapenko via Phabricator via llvm-commits]

m.ostapenko added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:247
+  // The sizeof (struct pthread) is valid for GLIBC 2.20.
+  val = 1152;
+  atomic_store(&kThreadDescriptorSize, val, memory_order_relaxed);
----------------
zatrazz wrote:
> This is not what I am seeing on my environment:
> 
> 2.25	-	1216
> 2.24	-	1216
> 2.23	-	1216
> 2.22	-	1120
> 2.21	-	1120
> 2.20	-	1120
> 
> The 2.22 to 2.23 change (cause by 3e2ee6f0e3471ce commit) removed HAVE_FORCED_UNWIND and thus 'struct pthread' adds a 'struct _Unwind_Exception' regardless if architecture defined or not HAVE_FORCED_UNWIND.
Oh, my bad, should be fixed.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:202
     int minor = internal_simple_strtoll(buf + 8, &end, 10);
-    if (end != buf + 8 && (*end == '\0' || *end == '.')) {
+    if (end != buf + 8 && (*end == '\0' || *end == '.' || *end == '-')) {
       int patch = 0;
----------------
I don't really like this change . Perhaps we can create some white list of terminator symbols, or just drop the check?


Repository:
  rL LLVM

https://reviews.llvm.org/D29586