[PATCH] D28913: ThinLTOBitcodeWriter: Strip debug info from merged module.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D28913#670212, @pcc wrote:

> (FWIW, I wouldn't necessarily call this a "temporary" approach. I'd say that the benefit of adding the flag to CloneModule should first be proven through benchmarking.)


One could argue on the opposite. Before you prove that it does not matter, this can't be called anything else than temporary.
Making the software 1% slower here, and here, and here, and here, leads to a bloated project. If we have code reviews it is also to catch what we *know* immediately isn't "right" and not build technical debt.


https://reviews.llvm.org/D28913