[PATCH] D28913: ThinLTOBitcodeWriter: Strip debug info from merged module.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 7 16:57:11 PST 2017
pcc added a comment.
In https://reviews.llvm.org/D28913#670198, @tejohnson wrote:
> This LGTM as a temporary approach - but please wait for Mehdi. Was https://reviews.llvm.org/D29240 the fix of the root cause of the bot failure?
Yes.
> Is this fix required to work around a breakage now, or just an optimization to remove unnecessary debug info?
The latter.
(FWIW, I wouldn't necessarily call this a "temporary" approach. I'd say that the benefit of adding the flag to CloneModule should first be proven through benchmarking.)
https://reviews.llvm.org/D28913
More information about the llvm-commits
mailing list