[PATCH] D29689: [ELF] Handle output section alignment in linker scripts
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 7 15:43:28 PST 2017
phosek added inline comments.
================
Comment at: ELF/LinkerScript.cpp:372
+
+ if (Cmd->AlignExpr) {
+ uint32_t Align = Cmd->AlignExpr(0);
----------------
ruiu wrote:
> I don't know if this is the right place to add this code. Have all output sections been created when the control reaches here? I think LinkerScript<ELFT>::assignOffsets is a better place to do this.
I think they should, but `assignOffsets` would definitely work.
Repository:
rL LLVM
https://reviews.llvm.org/D29689
More information about the llvm-commits
mailing list