[llvm] r294357 - Fix some missing negations in the traits checking from r294349

[Justin Lebar via llvm-commits]

> Mehdi and Justin: should `git llvm push` fail if there are changes in the checkout?

:shrug: I'm fine with that.  Maybe it should only fail if you didn't
specify a particular commit to push.  (i.e. "git llvm push" would fail
safe, but "git llvm push deadbeef" would not.)

I'd also be OK checking if stdin is a tty and if so, prompting.

On Tue, Feb 7, 2017 at 2:45 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
> Thanks David, I just saw the buildbot emails now.
>
> I take the blame, but an interesting behaviour in the monorepo `git llvm push` script made it easy for me to make a mistake.  I found the same failures locally, fixed them to get `ninja check` clean, and then pushed... neglecting to amend my commit.
>
> Mehdi and Justin: should `git llvm push` fail if there are changes in the checkout?
>
>> On 2017-Feb-07, at 13:31, David Blaikie via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: dblaikie
>> Date: Tue Feb  7 15:31:03 2017
>> New Revision: 294357
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=294357&view=rev
>> Log:
>> Fix some missing negations in the traits checking from r294349
>>
>> Modified:
>>    llvm/trunk/unittests/ADT/IListIteratorTest.cpp
>>
>> Modified: llvm/trunk/unittests/ADT/IListIteratorTest.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/IListIteratorTest.cpp?rev=294357&r1=294356&r2=294357&view=diff
>> ==============================================================================
>> --- llvm/trunk/unittests/ADT/IListIteratorTest.cpp (original)
>> +++ llvm/trunk/unittests/ADT/IListIteratorTest.cpp Tue Feb  7 15:31:03 2017
>> @@ -159,15 +159,15 @@ TEST(IListIteratorTest, ReverseConstruct
>>   EXPECT_EQ(CL.rbegin(), const_reverse_iterator(CL.end()));
>>
>>   // Confirm lack of implicit conversions.
>> -  static_assert(std::is_convertible<iterator, reverse_iterator>::value,
>> +  static_assert(!std::is_convertible<iterator, reverse_iterator>::value,
>>                 "unexpected implicit conversion");
>> -  static_assert(std::is_convertible<reverse_iterator, iterator>::value,
>> +  static_assert(!std::is_convertible<reverse_iterator, iterator>::value,
>>                 "unexpected implicit conversion");
>>   static_assert(
>> -      std::is_convertible<const_iterator, const_reverse_iterator>::value,
>> +      !std::is_convertible<const_iterator, const_reverse_iterator>::value,
>>       "unexpected implicit conversion");
>>   static_assert(
>> -      std::is_convertible<const_reverse_iterator, const_iterator>::value,
>> +      !std::is_convertible<const_reverse_iterator, const_iterator>::value,
>>       "unexpected implicit conversion");
>> }
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>