[PATCH] D29674: [AMDGPU] Split R600/SI getFrameIndexReference and emit stack object offsets for SI

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Target/AMDGPU/R600FrameLowering.cpp:33
+  // Start the offset at 2 so we don't overwrite work group information.
+  // XXX: We should only do this when the shader actually uses this
+  // information.
----------------
XXX?


================
Comment at: test/CodeGen/AMDGPU/debugger-variable-locations.ll:7
+
+; CHECK: DW_AT_name [DW_FORM_strp] ( .debug_str[0x00000025] = "GlobA")
+; CHECK: DW_AT_location [DW_FORM_block1] (<0x09> 03 00 00 00 00 10 01 16 18 )
----------------
CHECK-NEXT to make sure the two belong together?


https://reviews.llvm.org/D29674