[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 7 12:44:37 PST 2017
dblaikie added inline comments.
================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:847
+ // DW_AT_address_class for pointer and reference types.
+ if (Asm->TM.targetSupportsMultipleAddressSpaces() &&
+ (Tag == dwarf::DW_TAG_pointer_type ||
----------------
Similar feedback to one of the other patches - whether or not this hook (targetSupportsMultipleAddressSpaces) is needed or if the "not default address space" (or not zero adderss space) would suffice.
https://reviews.llvm.org/D29670
More information about the llvm-commits
mailing list