[PATCH] D29671: [DebugInfo] Add address space when creating DIDerivedTypes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGenOpenCL/debugger-pointer-address-space.cl:1
+// RUN: %clang -cl-std=CL2.0 -emit-llvm -g -O0 -S -target amdgcn-amd-amdhsa -mcpu=fiji -o - %s | FileCheck %s
+
----------------
dblaikie wrote:
> Seems like a lot of test coverage for 4 changes. Is it all needed? I'd expect roughly 4 tests for these 4 changes. One for each that demonstrates the addr space is plumbed through. Probably no need to test that all addr spaces work in each context - because this code is pretty/entirely orthogonal to the particular address space.
I think it's better to explicitly test all address spaces the target cares about


https://reviews.llvm.org/D29671