[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1078-1082
+    unsigned AddressSpace = 0;
+    if (Record.size() > 12) {
+      if (Record[12] > (uint64_t)std::numeric_limits<unsigned>::max())
+        return error("Address space value is too large");
+      AddressSpace = Record[12];
----------------
arsenm wrote:
> Where is this limit from? The enforced address space limit in other places is 24 bits
I was not sure about that. Will fix. Thanks.


https://reviews.llvm.org/D29670