[PATCH] D29673: [DebugInfo] Append extended dereferencing mechanism to variables' DIExpression for targets that support more than one address space

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3351
+  // Append extended dereferencing mechanism for VD's address space.
+  if (CGM.getTarget().targetSupportsMultipleAddressSpaces()) {
+    unsigned AddressSpace =
----------------
Is this hook necessary? Can you just not append if the returned address space is the default, or do we want to be explicit even with private address space?


https://reviews.llvm.org/D29673