[PATCH] D29577: [PM/LCG] Teach the LazyCallGraph how to replace a function without disturbing the graph or having to update edges.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 11:30:50 PST 2017


davide added a comment.

While this patch is large, a fair amount of it are just mechanical changes. I wasn't able to spot any obvious mistake, but I would appreciate another pair of eyes looking at it (@sanjoy ?)



================
Comment at: include/llvm/Analysis/LazyCallGraph.h:330-331
+
+    /// Tests whether the node has been populated with edges.
+    operator bool() const { return (bool)Edges; }
+
----------------
Not sure if `static_cast<bool>` works here, but I would prefer that, if possible.


https://reviews.llvm.org/D29577





More information about the llvm-commits mailing list