[PATCH] D29519: Add PredicateInfo utility and printing pass

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

I took another closer look and I convinced myself this is correct. Just one comment inline.



================
Comment at: lib/Transforms/Utils/PredicateInfo.cpp:111-124
+    if (!ADef && !A.Use) {
+      assert(A.PInfo &&
+             "No def, no use, and no predicateinfo should not occur");
+      assert(isa<PredicateAssume>(A.PInfo) &&
+             "Middle of block should only occur for assumes");
+      ADef = cast<PredicateAssume>(A.PInfo)->AssumeInst;
+    }
----------------
This is pretty much the same code. I would appreciate if you could consider the usage a lambda or an helper, if possible.


https://reviews.llvm.org/D29519