[PATCH] D29616: LoadStoreVectorizer: Split even sized illegal chains properly

[Volkan Keles via Phabricator via llvm-commits]

volkan added a comment.

The changes in LoadStoreVectorizer LGTM.

Thanks,
Volkan



================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:132
 
+bool AMDGPUTTIImpl::isLegalToVectorizeLoadChain(unsigned ChainSizeInBytes,
+                                                unsigned Alignment,
----------------
I think a separate function for this check would be better. You can call that function in isLegalToVectorizeLoadChain and isLegalToVectorizeStoreChain.


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:137
+  // them later if they may access private memory. We don't have enough context
+  // here, and leglization can handle it.
+  if (AddrSpace == AMDGPUAS::PRIVATE_ADDRESS) {
----------------
Typo: legalization


https://reviews.llvm.org/D29616