[PATCH] D29185: [lit] Allow llvm's build and test systems to support paths with spaces

[ben via Phabricator via llvm-commits]

bd1976llvm updated this revision to Diff 87389.
bd1976llvm added a comment.

I did some more testing of this patch. It turns out that in my testing on windows I had a space in the path to the llvm source code directory but not a space in the path to the build directory. Adding a space in the path to the build directory revealed some problems with the original patch that this new patch addresses.

1. Needed to quote one more argument in the AddLLVM.cmake for --version-script
2. On Linux the "%/[STpst]" substitutions were replacing the '\' escape character with '/'. I have reworked the default substitutions code so that normalization is done before escaping.
3. I have escaped spaces in paths for more substitutions in lit.cfg


https://reviews.llvm.org/D29185

Files:
  BugPoint/compile-custom.ll
  DebugInfo/llvm-symbolizer-split-dwarf-empty.test
  DebugInfo/llvm-symbolizer.test
  GetRepositoryPath
  GetSourceVersion
  GettingStartedVS.rst
  LibDriver/libpath.test
  Object/mri-addmod.test
  Object/nm-archive.test
  Other/ResponseFile.ll
  ThinLTO/X86/prefix_replace.ll
  Transforms/GCOVProfiling/function-numbering.ll
  Transforms/GCOVProfiling/global-ctor.ll
  Transforms/GCOVProfiling/linezero.ll
  Transforms/GCOVProfiling/linkagename.ll
  Transforms/GCOVProfiling/return-block.ll
  Transforms/GCOVProfiling/three-element-mdnode.ll
  Transforms/GCOVProfiling/version.ll
  lit.cfg
  lit/lit/ShUtil.py
  lit/lit/TestRunner.py
  lit/lit/util.py
  lit/tests/lit.cfg
  lit/tests/unit/ShUtil.py
  modules/AddLLVM.cmake
  tools/llvm-profdata/input-dir.test
  tools/llvm-profdata/input-filenames.test
  tools/llvm-symbolizer/coff-dwarf.test
  tools/llvm-symbolizer/coff-exports.test
  tools/llvm-symbolizer/dsym.test
  tools/sanstats/elf.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29185.87389.patch
Type: text/x-patch
Size: 30819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170207/89b51b5a/attachment.bin>