[PATCH] D29618: Avoid skipping instructions in IndVarSimplify::sinkUnusedInvariants

[Roman Morylev via Phabricator via llvm-commits]

rmorylev added inline comments.


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:2290
   while (I != Preheader->begin()) {
     --I;
     // New instructions were inserted at the end of the preheader.
----------------
At the end of the loop I is pointing at the next instruction to consider, so this decrement will skip it


================
Comment at: test/Transforms/IndVarSimplify/sink-all.ll:23
+; CHECK: for.end:
+; CHECK: mul
+; CHECK: mul
----------------
Verify that all 3 instructions from preheader are sinked


Repository:
  rL LLVM

https://reviews.llvm.org/D29618