[PATCH] D29363: [XRAY] A Color Choosing helper for XRay Graph

[Alexis Shaw via Phabricator via llvm-commits]

varno marked 2 inline comments as done.
varno added inline comments.


================
Comment at: tools/llvm-xray/xray-color-helper.h:60
+  ColorHelper(DivergingScheme S);
+  std::string getColor(double Point);
+};
----------------
dberris wrote:
> I might be missing something, but would it work better if you returned an RGB tuple?
Not really, I would just have to convert it later, and the format specification is a little hard. If someone wants raw RGB tuples (unlikely) then they can add another function to do so easily enough. But as it is I would never use such a function.


https://reviews.llvm.org/D29363