[PATCH] D29611: RegisterCoalescer: Fix joinReservedPhysReg()

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 16:51:02 PST 2017


MatzeB created this revision.
Herald added a subscriber: mcrosier.

Wei correctly pointed out in the discussion of https://reviews.llvm.org/D29436 that we cannot properly deal with control flow even with the fixes proposed there. This is also hard to fix as we do not track liveness for reserved registers (we only have the defs but no full live ranges available). So instead of trying to fix things for control flow we should simply abort:

joinReservedPhysReg() can only deal with a liverange in a single basic
block when copying from a vreg into a physreg.


Repository:
  rL LLVM

https://reviews.llvm.org/D29611

Files:
  lib/CodeGen/RegisterCoalescer.cpp
  test/CodeGen/AArch64/regcoal-physreg.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29611.87338.patch
Type: text/x-patch
Size: 4946 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170207/a8990803/attachment.bin>


More information about the llvm-commits mailing list