[PATCH] D28182: COFF: tie the execute and the PDB together

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 14:24:47 PST 2017


inglorion added inline comments.


================
Comment at: COFF/Writer.cpp:307
+    createPDB(Config->PDBPath, Symtab, SectionTable, BuildId->DI);

   if (auto EC = Buffer->commit())
     fatal(EC, "failed to write the output file");
----------------
This is causing the linker to crash for me, because BuildId is nullptr. @compnerd, does that suggest a problem and a fix, or shall I do some more digging and cook up a patch?


Repository:
  rL LLVM

https://reviews.llvm.org/D28182





More information about the llvm-commits mailing list