[lld] r294006 - Handle numbers followed by ":" in linker scripts.
Mikulin, Dmitry via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 6 13:39:10 PST 2017
I created a review in case we decide to go with some version of the simple fix proposed earlier.
https://reviews.llvm.org/D29603
Thanks.
Dmitry.
> On Feb 6, 2017, at 7:27 AM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote:
>
> Rui Ueyama <ruiu at google.com> writes:
>>
>> The current parser has limitations as it was discussed in the thread about
>> linking the Linux kernel with LLD. Maybe it's time to rewrite the lexer to
>> fix all the issues once and for all?
>
> I think they are independent issues. The following version script is
> valid
>
> { global: foo; local : bar; };
>
> so I think it is a case where we do need to have ':' be its own token
> and handle the complication in the parser.
>
> Or are you suggesting changing the lexer to return "local:" when it gets
> to "local :"?
>
> Cheers,
> Rafael
>
More information about the llvm-commits
mailing list