[PATCH] D29570: Fix the samplepgo indirect call promotion bug: we should not promote a direct call.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh added inline comments.


================
Comment at: include/llvm/IR/CallSite.h:121
+        return false;
+    }
+    return true;
----------------
davidxl wrote:
> danielcdh wrote:
> > davidxl wrote:
> > > getCalledValue constant case?
> > I used "stripPointerCasts" on getCalledValue() so that this is not needed any more.
> how is it so?
stripPointerCasts comment says "Strip off pointer casts, all-zero GEPs, and aliases.", so for the constants (alias), it will give the actual function that it aliases to.


https://reviews.llvm.org/D29570