[compiler-rt] r294037 - [scudo] 32-bit quarantine sizes adjustments and bug fixes

[Kostya Kortchinsky via llvm-commits]

This should be fixed with https://reviews.llvm.org/rL294199.

On Mon, Feb 6, 2017 at 12:25 PM, Vitaly Buka <vitalybuka at google.com> wrote:

> This patch breaks compiler-rt tests http://lab.llvm.org:8011/
> builders/sanitizer-x86_64-linux/builds/801/steps/test%
> 20standalone%20compiler-rt/logs/stdio
>
> On Mon, Feb 6, 2017 at 8:18 AM Kostya Kortchinsky via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Jonas, feel free to LGTM it to speed up the process :)
>>
>> On Mon, Feb 6, 2017 at 7:20 AM, Kostya Kortchinsky <kostyak at google.com>
>> wrote:
>>
>> Hi,
>>
>> https://reviews.llvm.org/D29527 is out for review to fix this.
>>
>> Kostya
>>
>> On Mon, Feb 6, 2017 at 1:18 AM, Hahnfeld, Jonas <
>> Hahnfeld at itc.rwth-aachen.de> wrote:
>>
>> Hi,
>>
>> > -----Original Message-----
>> > From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
>> Behalf
>> > Of Kostya Kortchinsky via llvm-commits
>> > Sent: Friday, February 03, 2017 9:50 PM
>> > To: llvm-commits at lists.llvm.org
>> > Subject: [compiler-rt] r294037 - [scudo] 32-bit quarantine sizes
>> adjustments
>> > and bug fixes
>> >
>> > Author: cryptoad
>> > Date: Fri Feb  3 14:49:42 2017
>> > New Revision: 294037
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=294037&view=rev
>> > Log:
>> > [scudo] 32-bit quarantine sizes adjustments and bug fixes
>> >
>> > Summary:
>> > The local and global quarantine sizes were not offering a distinction
>> for
>> > 32-bit
>> > and 64-bit platforms. This is addressed with lower values for 32-bit.
>> >
>> > When writing additional tests for the quarantine, it was discovered that
>> > when calling some of the allocator interface function prior to any
>> > allocation
>> > operation having occured, the test would crash due to the allocator not
>> > being
>> > initialized. This was addressed by making sure the allocator is
>> initialized
>> > for
>> > those scenarios.
>> >
>> > Relevant tests were added in interface.cpp and quarantine.cpp.
>> >
>> > Last change being the removal of the extraneous link dependencies for
>> the
>> > tests thanks to rL293220, anf the addition of the gc-sections linker
>> flag.
>> >
>> > Reviewers: kcc, alekseyshl
>> >
>> > Reviewed By: alekseyshl
>> >
>> > Subscribers: llvm-commits
>> >
>> > Differential Revision: https://reviews.llvm.org/D29341
>> >
>> > Modified:
>> >     compiler-rt/trunk/lib/scudo/scudo_allocator.cpp
>> >     compiler-rt/trunk/lib/scudo/scudo_flags.cpp
>> >     compiler-rt/trunk/lib/scudo/scudo_flags.inc
>> >     compiler-rt/trunk/test/scudo/alignment.cpp
>> >     compiler-rt/trunk/test/scudo/double-free.cpp
>> >     compiler-rt/trunk/test/scudo/interface.cpp
>> >     compiler-rt/trunk/test/scudo/lit.cfg
>> >     compiler-rt/trunk/test/scudo/malloc.cpp
>> >     compiler-rt/trunk/test/scudo/memalign.cpp
>> >     compiler-rt/trunk/test/scudo/mismatch.cpp
>> >     compiler-rt/trunk/test/scudo/options.cpp
>> >     compiler-rt/trunk/test/scudo/overflow.cpp
>> >     compiler-rt/trunk/test/scudo/preinit.cpp
>> >     compiler-rt/trunk/test/scudo/quarantine.cpp
>> >     compiler-rt/trunk/test/scudo/realloc.cpp
>> >     compiler-rt/trunk/test/scudo/secondary.cpp
>> >     compiler-rt/trunk/test/scudo/sized-delete.cpp
>> >     compiler-rt/trunk/test/scudo/sizes.cpp
>> >
>> > [...]
>> >
>> > Modified: compiler-rt/trunk/test/scudo/lit.cfg
>> > URL: http://llvm.org/viewvc/llvm-project/compiler-
>> > rt/trunk/test/scudo/lit.cfg?rev=294037&r1=294036&r2=294037&view=diff
>> > ==========================================================
>> > ====================
>> > --- compiler-rt/trunk/test/scudo/lit.cfg (original)
>> > +++ compiler-rt/trunk/test/scudo/lit.cfg Fri Feb  3 14:49:42 2017
>> > @@ -19,12 +19,12 @@ config.suffixes = ['.c', '.cc', '.cpp']
>> >  # C flags.
>> >  c_flags = ([config.target_cflags] +
>> >             ["-std=c++11",
>> > -           "-lrt",
>> > -           "-ldl",
>>
>> With this change, I'm getting link errors for dlsym, shm_open and
>> shm_unlink.
>> Can we read these libraries?
>>
>> Thanks,
>> Jonas
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170206/3fa9dda7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4845 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170206/3fa9dda7/attachment.bin>