[PATCH] D29570: Fix the samplepgo indirect call promotion bug: we should not promote a direct call.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 12:05:35 PST 2017


davidxl added inline comments.


================
Comment at: include/llvm/IR/CallSite.h:116
+  bool isIndirectCall() const {
+    if (dyn_cast<FunTy>(getCalledValue()->stripPointerCasts()))
+      return false;
----------------
check if getCalledValue nullness?


================
Comment at: include/llvm/IR/CallSite.h:121
+        return false;
+    }
+    return true;
----------------
getCalledValue constant case?


https://reviews.llvm.org/D29570





More information about the llvm-commits mailing list