[PATCH] D29511: [X86]: Don't set a regmask on conditional tail calls (PR31257)

[Michael Kuperstein via Phabricator via llvm-commits]

mkuper added a comment.

Sorry for the lag, Hans.

I thought about this a bit more, and I'm not sure I'm a fan of this, even though I basically suggested something similar on Friday.

Two issues:

1. I'm still not sure this won't have any unintended consequences.
2. Having BuildMI return an instruction that requires you to remove an operand for correctness seems rather inelegant. I agree that this is probably "safer" than removing IsCall, and that is probably the only code that will ever construct a TCRETURNdi64cc MI, but, still...

I don't have any good ideas, though.


https://reviews.llvm.org/D29511