[PATCH] D29490: [ELF] - Use SignExtend when reading R_386_PC8, R_386_PC16 addends.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 10:58:34 PST 2017


On Mon, Feb 6, 2017 at 10:32 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
> > ruiu added a comment.
> >
> > Don't you need to sign-extend not only these two but all operands that
> have signed values, do you?
>
> True, but it is probably better to have followup patches for that, no?
>

Yes. Please submit.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170206/ea6a8184/attachment.html>


More information about the llvm-commits mailing list