[PATCH] D29586: [lsan] Enable LSan for arm Linux
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 6 10:57:26 PST 2017
rengolin added a reviewer: zatrazz.
rengolin added a comment.
You seem to be enabling it on soft and hard float. Did you test on both environments? What type of hardware did you test this?
================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1253
+ ((unsigned int *)child_stack)[1] = (uptr)arg;
+ register int r0 __asm__("r0") = flags;
+ register void *r1 __asm__("r1") = child_stack;
----------------
This sequence doesn't coincide with the order of parameters above, and can lead to unexpected results.
Why do you need to reserve the registers in this code at all?
Repository:
rL LLVM
https://reviews.llvm.org/D29586
More information about the llvm-commits
mailing list