[PATCH] D29526: Add an option to use the MSVC linker to link LTO-generated object files.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/DriverUtils.cpp:647
+  Executor E("link.exe");
+  E.add("/nologo");
+  for (TemporaryFile &T : Temps)
----------------
pcc wrote:
> Should this create a response file instead of passing the arguments directly?
Done.


================
Comment at: lld/COFF/DriverUtils.cpp:652
+    switch (Arg->getOption().getID()) {
+    case OPT_INPUT:
+    case OPT_defaultlib:
----------------
pcc wrote:
> Should this strip all inputs or just bitcode files?
Strip only bitcode files.


================
Comment at: lld/COFF/DriverUtils.cpp:658
+    case OPT_msvclto:
+      // LLD-specific options are stripped.
+      break;
----------------
pcc wrote:
> What about `/opt:lld*`?
lldmap and lldmap_file are only options that start with lld in COFF.


================
Comment at: lld/COFF/SymbolTable.cpp:354
 
-void SymbolTable::addCombinedLTOObjects() {
-  if (BitcodeFiles.empty())
-    return;
-
+std::vector<StringRef> SymbolTable::compile() {
   LTO.reset(new BitcodeCompiler);
----------------
pcc wrote:
> Maybe call this something like `compileBitcodeFiles`?
Done.


https://reviews.llvm.org/D29526